Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make fixes to ed25519 sign method + improve tests #195

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: make fixes to ed25519 sign method + improve tests #195

merged 4 commits into from
Oct 23, 2024

Conversation

elribonazo
Copy link
Contributor

Description:

After some investigation, we are returning a hex encoded buffer with the signature in JS which causes compatibility issues across SDK and we are also improving the test coverage for ed25519 by using the same values on all platforms we test

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo force-pushed the feature/improve-ed branch 3 times, most recently from 6651a6c to 8c8fd6c Compare September 30, 2024 12:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Code Coverage

File Coverage [65.00%] ❌
apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
Total Project Coverage 88.94% ❌

@elribonazo
fix: ed25519 for JS fixes on signatures
c61204c 
Signed-off-by: Javier Ribó <elribonazo@gmail.com>
@elribonazo
fix: improve submodules
8a81816 
Signed-off-by: Javier Ribó <elribonazo@gmail.com>
@elribonazo
fix: building on more recent macos version
8cf5da6 
Signed-off-by: Javier Ribó <elribonazo@gmail.com>
@elribonazo
fix: remove rustup custom version
610c49a 
Signed-off-by: Javier Ribó <elribonazo@gmail.com>
@elribonazo elribonazo merged commit 354c9bd into main Oct 23, 2024
5 checks passed
@elribonazo elribonazo deleted the feature/improve-ed branch October 23, 2024 10:40
@hyperledger-bot
Copy link
Member

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

@curtis-h curtis-h curtis-h approved these changes

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elribonazo @hyperledger-bot @curtis-h @goncalo-frade-iohk